search

jzbruno / terraform-aws-lex-examples

Amazon Lex Bot examples from the AWS console implemented with the Terraform AWS Provider
8 stars 12 forks source link

question about AWS Lex resource with terraform #1

Closed nbmustafa closed 3 years ago

nbmustafa commented 4 years ago

This is an excellent example. but wondering if this is yet ready or not?

Curios to question this is just an example of how these resources will look like when the following three PRs are merged is that correct? New Resource: aws_lex_intent #8917 New Resource: aws_lex_bot #8918 New Resource: aws_lex_bot_alias #8919

jzbruno commented 4 years ago

@nashvan Hello, I would recommend waiting until the other PRs are merged. After the review and merge of the slot type resource a few items were identified that need to be updated on the other PRs too. I am working this week to get them ready and with the help of the provider maintainers we should be able to get them reviewed and merged.

I will update these examples to match the provider code too.

nbmustafa commented 4 years ago

@jzbruno brilliant, thank you very much, your contribution is really highly appreciated. please let (mention me if possible) when the PRs are merged and your templates are updated accordingly. thank you so much again.

jzbruno commented 4 years ago

@nashvan I have updated the examples here, not much changed. They still don't include a lambda integration example. But they work with the code in the "add_aws_lex_bot_alias" branch which should be close to the final version once all the PRs are merged.

nbmustafa commented 4 years ago

@jzbruno thank you very much, I am following every single commit you do on fixing these stuffs on the terraform provider, really well done. your contribution is highly appreciated by the entire community. thank you heaps.

nbmustafa commented 4 years ago

@jzbruno I was wondering if it would be doable within the upcoming PR if we can import intent messages from a json file?

jzbruno commented 4 years ago

@nashvan I would say to create a new issue. I would rather not delay this release. Finally getting traction after 2 years. :)

nbmustafa commented 4 years ago

@jzbruno I garee with you. i will raise an issue later hopefully you can get on to that beside other three tracking issues you created.

Brilliant work. Thanks again.

jzbruno commented 3 years ago

Looks like this is all merged and available in 3.10.0 of the provider. :)

nbmustafa commented 3 years ago

I created an issue on their for adding capability to import intents from json file. Thank you again. You have done a womderful job.