search

jzelinskie / geddit

golang reddit api wrapper
BSD 3-Clause "New" or "Revised" License
164 stars 58 forks source link

Exported geddit.vote (which is now geddit.Vote) #17

Closed TheGreatPanda closed 8 years ago

TheGreatPanda commented 8 years ago

I exported geddit.vote. The old geddit.vote created interesting problems:

// This used to be impossible:
inp := getInputFromSomewhere()
var vote geddit.vote
switch inp {
case "up":
    vote = geddit.UpVote
case "down":
    vote = geddit.DownVote
    // Etc
}
jzelinskie commented 8 years ago

I hadn't considered this scenario. You should probably set some git credentials, the commit info is set to "Your Name".

TheGreatPanda commented 8 years ago

Sorry, I'm quite new to the whole git/github workflow :). So, now that I've set my credentials, what should I do?

jzelinskie commented 8 years ago

No problem! Changing the commit to contain your new author credentials is a little tricky for someone new to git. You're best off simply running git reset --hard 9a23e13 and making the change and committing it again with your new credentials set. Then you have to git push -f to overwrite the branch.

jzelinskie commented 8 years ago

Woah, didn't know github automatically closed PRs without any new commits.

TheGreatPanda commented 8 years ago

I'm going to submit a pull request now. Thanks so much for your help :100:.