search

jzfai / vue3-admin-plus

👏 An amazing admin framework of vue3
MIT License
848 stars 203 forks source link

showTagsView not cleared when false #75

Closed munkeywolf00 closed 1 year ago

munkeywolf00 commented 1 year ago

When showTagsView is false, height is not updated to where there should not be --tag-view-height. So it creates a "footer like" view below. I fixed this in my local and I forgot how I did it.

This case also happens during scroll in src/styles/index.scss.

dashboard-no-tags-views

dashboard-no-tags-views-inspect

jzfai commented 1 year ago

thanks for you advise

you can send the pr to fix it

munkeywolf00 commented 1 year ago

Sure. I will replicate it in new test and make a PR

munkeywolf00 commented 1 year ago

@jzfai Here is my PR: https://github.com/jzfai/vue3-admin-plus/pull/79