jzheng2017 / spotify-web-api-wrapper

Spotify API wrapper for Java
MIT License
50 stars 31 forks source link

feature/unwrap paging objects #91

Closed DanielVargaPublic closed 4 months ago

DanielVargaPublic commented 7 months ago

Description

Some functions in the BrowseApi class were returning objects that were wrappers around paging objects. These functions have been deprecated, and new functions, that return the paging objects themselves, have been added.

Fixes #9

Type of change

How Has This Been Tested?

Checklist:

jzheng2017 commented 5 months ago

Took a look at the PR. Looks good. One very minor thing. Can you end the deprecation javadoc with period instead of semicolon, otherwise it looks like half a sentence is missing. After that it's good to merge!

Good work :)

DanielVargaPublic commented 5 months ago

Took a look at the PR. Looks good. One very minor thing. Can you end the deprecation javadoc with period instead of semicolon, otherwise it looks like half a sentence is missing. After that it's good to merge!

Good work :)

Ah, muscle memory got me :D fixed it now, thank you!

jzheng2017 commented 4 months ago

The PR has been merged now. Thank you for your contribution!