jzillmann / gradle-jmh-report

A Gradle plugin building a visual report for JMH benchmarks
Apache License 2.0
46 stars 3 forks source link

jmhReport configuration cannot deal with JMH' default JSON file name and jmhReportOutput seems to be superfluous in the current implementation #5

Closed loxal closed 7 years ago

loxal commented 7 years ago

I am not using the JMH Gradle plugin because it's (1) currently broken on Windows (2) is a superfluous layer of indirection that not really provide any additional value and (3) does not work with (at least) Kotlin.

Hence I am using vanilla JMH which works just fine without any JMH plugin and creates a jmh-result.json file in the projects root which I reconfigured to be put in build/jmh-results.json.

However this plugins seems to have problems with a dash inside the default file name which is jmh-result.json and creates a broken report when I use jmhResultPath = project.file("build/jmh-result.json").

Also it seems like jmhReportOutput must point to a folder that contains the JSON results file and cannot be just any folder under build/.

jzillmann commented 7 years ago

@loxal Thanks for trying at least! :)

So a few things...