search

jzillmann / jmh-visualizer

Visually explore your JMH Benchmarks
https://jmh.morethan.io
GNU Affero General Public License v3.0
294 stars 22 forks source link

sort order of multi run broken #13

Closed kuehl closed 6 years ago

kuehl commented 6 years ago

use case: release 0.7.3 downloaded and docs-folder local unzipped. using a nanohttpd server with two wwwroots, one for jmh-visualizer-docs and the other for some jmh json reports with simplified run1-runX-naming convention. the display order differs sometimes (5%-10% of all forced page reloads) from the url sortorder leading to declined / improved benchmark results.

any idea?

thanks me

jzillmann commented 6 years ago

Hey @kuehl , sorry for late reply. So if i understand you correctly the general functionality is correct with your way of deployment, but there is some randomness when it comes to sorting ? And you mean the sorting of the different runs, so lets say run2 comes before run1 ?

Can you provide your run-names so i can experiment with it ?

kuehl commented 6 years ago

hi,

i build a sample:

jmhv.tar.gz

  1. download
  2. unzip
  3. ./gradlew run

browse url and force (F5) page reloads: the report ordering should sometimes change :confused:

jzillmann commented 6 years ago

Hey @kuehl think i found the problem and fixed it. Released 0.7.4 with the fix! Thanks for finding, reporting and providing the sample!

kuehl commented 6 years ago

thx for fixing :+1: the new version looks good: no more :dancer: dancing :man_dancing: url-parameter.