search

jzillmann / jmh-visualizer

Visually explore your JMH Benchmarks
https://jmh.morethan.io
GNU Affero General Public License v3.0
297 stars 23 forks source link

Support multi file gists #33

Closed leonard84 closed 3 years ago

leonard84 commented 3 years ago

It would be nice if the visualizer would support multi file gists, and treat them as if you've added separate gists.

For that you'd have to query the API to discover if a gist has multiple files https://docs.github.com/en/rest/reference/gists#get-a-gist and also to get the individual file links.

jzillmann commented 3 years ago

You have an example for that?

leonard84 commented 3 years ago

For a gist with multiple files, or for the api access?

To create a multi file gist, just create a normal gist, and then click on Add File on the bottom left.

jzillmann commented 3 years ago

@leonard84 It's in!

leonard84 commented 3 years ago

@jzillmann just checked it, and it works great, thanks.

willhains commented 2 years ago

@jzillmann @leonard84 Has this feature been removed or become broken? It doesn't seem to work. The example link in README.md only shows the result of one of the files in the gist.

jzillmann commented 2 years ago

@willhains Indeed... there was a bug. Thanks for reporting, it should work now!

willhains commented 2 years ago

Awesome, thanks!