Fails on file containing both parameterized and non-parameterized benchmarks

jzillmann / jmh-visualizer

Visually explore your JMH Benchmarks

https://jmh.morethan.io

GNU Affero General Public License v3.0

294 stars 22 forks source link

Fails on file containing both parameterized and non-parameterized benchmarks #38

Closed ablaagaard closed 2 years ago

ablaagaard commented 2 years ago

Tries to get the value of params[0][1] when params is null

jzillmann commented 2 years ago

Do you have an json result you can share which reproduces this ?

ablaagaard commented 2 years ago

Attached a test file. It seems the order is important - it fails when the non-parameterized results come after the parameterized

results.json.txt

jzillmann commented 2 years ago

Oh man, I'm really out of the code / mental model.. Anyway, I deployed a hack which should get you past the initial error. Please check it out (make sure it's version 0.9.6).

I think my code assumes that all tests within the class are homogenous (they use the same parameters, or not). So to be safe I would advise to build your test classes that way!