jzohrab / lute

DEPRECATED: LUTE (Learning Using Texts) is a self-hosted web app for learning language through reading, based on Learning with Texts (LWT)
The Unlicense
119 stars 10 forks source link

Fix Windows GitHub CI #72

Closed jzohrab closed 1 year ago

jzohrab commented 1 year ago

Branch fix_windows_no_mecab_ci has a .github action file defined.

Tests are failing, should be investigated.

https://github.com/jzohrab/lute/actions?query=branch%3Afix_windows_no_mecab_ci++

Ultimately, all of this work is just to verify that Windows installs work when MeCab isn't installed ... but this is still decent work to do, to see if there is anything wonky in the code.

Adding "help wanted" just in case someone sees this and wants to take a shot at fixing the busted tests!

jzohrab commented 1 year ago

Down to 4 acceptance test failures. All appear to happen only when the Term update form is submitted while reading ... maybe the page isn't reloading, maybe the form isn't submitting, I'm not sure ...

There were 4 failures:

1) App\Tests\acceptance\Reading_Test::test_reading_with_term_case_updates
Hola textitem click word status0 kwordmarked does not contain status1
Failed asserting that false is true.

D:\a\lute\lute\tests\acceptance\Contexts\ReadingContext.php:75
D:\a\lute\lute\tests\acceptance\Reading_Test.php:65

2) App\Tests\acceptance\Reading_Test::test_reading_with_term_multiple_parents_updates
Hola textitem click word status0 kwordmarked does not contain status1
Failed asserting that false is true.

D:\a\lute\lute\tests\acceptance\Contexts\ReadingContext.php:75
D:\a\lute\lute\tests\acceptance\Reading_Test.php:91

3) App\Tests\acceptance\Reading_Test::test_create_multiword_term
adios amigo grouped
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Hola/. /Adios amigo/.'
+'Hola/. /Adios/ /amigo/.'

D:\a\lute\lute\tests\acceptance\Contexts\ReadingContext.php:57
D:\a\lute\lute\tests\acceptance\Reading_Test.php:119

4) App\Tests\acceptance\Reading_Test::test_create_term_with_period
cap. textitem click word status0 kwordmarked does not contain status1
Failed asserting that false is true.

D:\a\lute\lute\tests\acceptance\Contexts\ReadingContext.php:75
D:\a\lute\lute\tests\acceptance\Reading_Test.php:1[47](https://github.com/jzohrab/lute/actions/runs/6365497801/job/17282570865#step:15:48)
jzohrab commented 1 year ago

... aaaaand fixed, by adding a bunch of delays in GitHub/Windows.

jzohrab commented 1 year ago

Merged into develop branch, will be launched later. Final run going through now.

jzohrab commented 1 year ago

All passed.