jzonta / FakerRestaurant

Food and Beverage names generate using fakerphp/faker
MIT License
90 stars 38 forks source link

Discard unmaintained version of faker #37

Closed osvaldoM closed 3 years ago

osvaldoM commented 3 years ago

Why are we adding this??

fzaninotto/faker has been sunset according to: https://marmelab.com/blog/2020/10/21/sunsetting-faker.html

How does this address the issue?

This PR updates composer.json to use fakerphp which is a maintained fork of the original library. This update also allows for this project to be easily installed in laravel 8 projects.

thatfiredev commented 3 years ago

We might want to update the README.md as well:

https://github.com/jzonta/FakerRestaurant/blob/455009b40e7f57c92ee8f194480c4840e92e9e09/README.md#L4

osvaldoM commented 3 years ago

Thanks @rosariopfernandes , I'll update it as well.

jzonta commented 3 years ago

Thanks @osvaldoM, I will do the PR and change it in README.md