search

jzonta / FakerRestaurant

Food and Beverage names generate using fakerphp/faker
MIT License
90 stars 38 forks source link

Change name values sa_AR #39

Closed mahkassem closed 2 years ago

mahkassem commented 3 years ago

This will change foodNames and meatNames to match Arabic region names

jzonta commented 3 years ago

Why did you remove pork meat? You made unnecessary changes to README.md

jzonta commented 3 years ago

PR Closed

mahkassem commented 2 years ago

Respect your hard work, sorry for the late response; I was very busy lately, Pork meat is not used in Arabic speaking countries, so a lot of customers don't find it relevant for demonstration.

jzonta commented 2 years ago

Respect your hard work, sorry for the late response; I was very busy lately, Pork meat is not used in Arabic speaking countries, so a lot of customers don't find it relevant for demonstration.

In this case, I'm reopening PR, but you need to remove your updates in readme.md, because it's not necessary. I appreciate your work and wait for a new commit removing the changes in the readme.

jzonta commented 2 years ago

I added your update through Cherry Pic, because you updated 2 PR files, it's not necessary. I mentioned you in Release v2.0.1

Thanks for your contribution