search

jzoss / Git-Source-Control-Provider

Git Source Control Provider is a visual studio plug-in that integrates Git with visual studio solution explorer.
https://github.com/jzoss/Git-Source-Control-Provider
GNU General Public License v2.0
78 stars 26 forks source link

Certain types of files not auto-added to source control when included in a project #105

Closed ddobrev closed 6 years ago

ddobrev commented 6 years ago

An example is https://github.com/CrossGeeks/AzurePushNotificationPlugin/blob/master/samples/AzurePushNotificationSample/AzurePushNotificationSample.Android/google-services.json .

ddobrev commented 6 years ago

@jzoss auto-addition also fails for .NET Standard 2.0 projects, XML files (vector drawables) in Xamarin.Android projects and asset catalogues in Xamarin.iOS projects. The first one is by far the most unpleasant because added files are (incorrectly) marked as added and I often forget to add them manually which leads to ruined commits and team members unable to build. Please comment whether you think you might have the chance to work on this.

jzoss commented 6 years ago

Lame.. I will take a look. Sorry.. I am just getting out of new baby fog.. I should really get a second person to help me out when I start slacking :)

jzoss commented 6 years ago

@ddobrev -- Ok I think I got it.. Can you try this release and tell me what you think. https://github.com/jzoss/Git-Source-Control-Provider/releases/download/GSCP-CI/GitSccProvider.vsix I think it may also fix #102

ddobrev commented 6 years ago

@jzoss .NET Standard and XML in Xamarin.Android both work just fine - thank you! This includes Xamarin.Forms pages which consist of two files, XAML and C# - both are added. Xamarin.iOS assets still don't work but as the state of the plug-in is now much better than it was, I strongly recommend an official release. The assets are rarely used so you deal with them whenever.

jzoss commented 6 years ago

Thanks @ddobrev