jzoss / libgitflow2sharp

Apache License 2.0
3 stars 1 forks source link

Suggestions #2

Closed teebeeno closed 8 years ago

teebeeno commented 8 years ago

A couple of simple tests, and some refactoring of the methods to reduce code duplication.

Tell me what you think.

In the init tests, I was thinking of maybe doing the init of the repo in the constructor, but ended up doing it seperatly in each test and instead use a constant for the repo-dir. Maybe it should be user configurable? but Why bother, c:\test is doable for me.

Thought maybe It was better to push to a new branch and pull it it in if you concure with my changes. I've actually never contributed on github, but I guess this is the github-way of doing things?

Don't know if it matters what branch I am on locally? I worked in master but pushed it as a new branch, hope that didn't screw things up.

teebeeno commented 8 years ago

BTW, really liked the fact that you prepared for the flexibility of using the git-config to define the prefixes for the key-branches. I guess you by doing it this way, can set up a global way of doing things, and have the flexibility to override it for specific repositories if need be. Simple and ingenious at the same time :+1:

jzoss commented 8 years ago

I wish I could take credit for that.. BUT.. I may have stolen that part of the code :)