Closed k-capehart closed 3 weeks ago
@iamber12 @0cv I'd appreciate both your eyes on this if you have time over the next week or two. It continues the work from #45 and would be part of a v2.0 release.
I'll be out for a couple weeks so no rush on it. I'll be able to return to it after but let me know if anything jumps out to you as a bad idea.
@k-capehart 2 days ago, I've swapped in my app my own PR by the latest commit of this PR and this seems to be working as before 👍
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 87.25490%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 86.45%. Comparing base (
32f00cf
) to head (92f2e72
).
Files | Patch % | Lines |
---|---|---|
dml.go | 81.81% | 10 Missing and 4 partials :warning: |
composite.go | 83.33% | 7 Missing :warning: |
salesforce.go | 89.74% | 3 Missing and 1 partial :warning: |
bulk.go | 97.72% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ccoVeille Since you're reviewing, how do you feel about returning the SalesforceResult
and SalesforceResults
as pointers? That's how I wrote it in this PR initially but now I can't think of any good reason why that's better than just returning the value. Any opinions?
I'm fine with pointer or not.
The first one is supposed to avoid using more memory.
But I'm unsure when the result is a map or a slice.
A benchmark would help here maybe
addresses: #42 continues work from: https://github.com/k-capehart/go-salesforce/pull/45
SalesforceResult
for single record operationsSalesforceResults
for Collection and Composite operationsSalesforceResult
array andHasErrors
propertySuccessfulRecords
andFailedRecords
toBulkJobResults
response fromGetJobResults()
continue
instead of abreak
)TODO: