search

k-donn / plasmoid-wunderground

A Plasma 5/6 widget for showing data from Wunderground PWS
https://store.kde.org/p/2135799
GNU General Public License v2.0
35 stars 12 forks source link

Text is not scaled to fit inside widget boundaries #29

Open picorealm opened 2 years ago

picorealm commented 2 years ago

Describe the bug The text of the widget is too large to fit inside the boundaries of the widget and is unreadable.

To Reproduce For Compact Representation Font is set to Default, Font size is set to 28. For Full Representation Property Header Text Size is set to 16, Property Text Size 12, Temperature Text Size 18. Am using a High DPI 3840x2160 43" display with KDE Plasma display scaling set to 168.75%.

Screenshots See attached

Desktop (output of plasmashell --version && kf5-config --version): plasmashell 5.23.3 Qt: 5.15.2 KDE Frameworks: 5.88.0 kf5-config: 1.0

plasma-wunderground widget issue

rocketfuelindustries commented 2 years ago

Same issue

Compact: Default, 50 Full: 16, 12, 20. Am using a High DPI 3840x2160, KDE Plasma display scaling set to 100%.

Desktop (output of plasmashell --version && kf5-config --version): plasmashell 5.23.5 Qt: 5.15.2 KDE Frameworks: 5.90.0 kf5-config: 1.0 Screenshot_20220121_142958

k-donn commented 2 years ago

Thank you for using my widget and creating this issue!

I will adjust the calculation for the various rendering sizes to account for high dpi devices.

Thank you again for understanding my busy schedule and any delays!

joickle commented 1 year ago

As a temporary fix, changing lines 60 and 61 in ~/.local/share/plasma/plasmoids/com.github.k-donn.plasmoid-wunderground/contents/main.qml fixed it for me on a 4k display with 144 dpi:

Layout.preferredWidth: 900
Layout.preferredHeight: 500
k-donn commented 1 year ago

Hello, just wanted to touch base to say that I have not forgotten about this. I recently figured out how to test high-dpi mode on my non-high-dpi screen. Upcoming changes to fix this!

abrouwers commented 1 year ago

Thanks for posting this, I couldn't figure out how to get everything to fit. Hopefully the fix is still incoming!

k-donn commented 1 year ago

Going forward, I think the best thing is just to make the full representation size configurable in settings.

Doing some testing, it has the same problem as #27 with the size not working after session restarts and first loading.

I'll push out some changes onto release with a possible change.

Cloning this repo and installing the plasmoid from the release branch will let everyone test how it goes on high DPI screens. It can be installed from the repo with kpackagetool5.

Thanks for reporting back!