search

k-int / gokb-phase1

Original GOKb repo - Moving to https://github.com/openlibraryenvironment/gokb
http://www.gokb.org
Other
11 stars 5 forks source link

Last updated column on Packages page not updating #579

Closed jhsolomon closed 7 years ago

jhsolomon commented 7 years ago

I just ingested this package, but the web app does not reflect the current date/time.

image

ianibo commented 7 years ago

Fixed an issue where only the last updated date was being used to find records for indexing in elasticsearch. Newly created records don't have a last updated date, only a dateCreated so were being skipped. Fixed issue, deployed, running full re-index now.

ianibo commented 7 years ago

lastUpdated is only touched for updated packages - for new packages the dateCreated field is populated. Can add the dateCreated field to list display if that helps?

jhsolomon commented 7 years ago

No, that's ok, we don't need the dateCreated field on that page view.

However, just to clarify, this package was not a newly created package, it was an updated package.

sosguthorpe commented 7 years ago

So I think this is because the Package doesn't actually change. Only the associated TIPPs are changed and I would think that this is the same behaviour as live. Maybe we should look at this in the next phase as I'm pretty sure it's "as live" and also none-breaking?

jhsolomon commented 7 years ago

fixed 1/10/17