search

k-int / gokb-phase1

Original GOKb repo - Moving to https://github.com/openlibraryenvironment/gokb
http://www.gokb.org
Other
11 stars 5 forks source link

"Close all" review tasks not closing tasks #592

Closed jhsolomon closed 7 years ago

jhsolomon commented 7 years ago

When I select the checkbox next to Cause to select all of the items on the list, and then try to use the Close action, it does not close any of the items.

image

ianibo commented 7 years ago

Digging...

ianibo commented 7 years ago

@sosguthorpe - Can you take a quick peek at ./gokb/grails-app/assets/javascripts/gokb/action-forms.js -- around line 100 - looks like it always returns false - calls gokb.confirm as defined in ./gokb/grails-app/assets/javascripts/gokb/application.grass.js - and I don't really follow what it's trying to do -- The close action works fine stand alone (from the RR detail page) but seems to choke for bulk action.

sosguthorpe commented 7 years ago

That seems correct. The false is just for some browsers so the default is to prevent the form submission. The form.submit() method that is called when the "Confirm" is actioned should submit the form upon Confirmation. I'll take a look in the a.m. and get to the bottom of what is (not) happening.

ianibo commented 7 years ago

Brill, thanks!

On 26 January 2017 at 13:17, sosguthorpe notifications@github.com wrote:

That seems correct. The false is just for some browsers so the default is to prevent the form submission. The form.submit() method that is called when the "Confirm" is actioned should submit the form upon Confirmation. I'll take a look in the a.m. and get to the bottom of what is (not) happening.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/592#issuecomment-275385749, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQIxuFGrM-EIyr4oAQG2CiU8HF74wrks5rWJzZgaJpZM4Lsijd .

-- Ian Ibbotson W: http://ianibbo.me E: ianibbo@gmail.com skype: ianibbo twitter: ianibbo GoodReads: https://www.goodreads.com/user/show/3106516-ian-ibbotson

sosguthorpe commented 7 years ago

Pushed a fix.

jhsolomon commented 7 years ago

fixed 1/31/17