k-int / gokb-phase1

Original GOKb repo - Moving to https://github.com/openlibraryenvironment/gokb
http://www.gokb.org
Other
11 stars 5 forks source link

500 Error when I click on Platform link from TIPP page #596

Closed jhsolomon closed 7 years ago

jhsolomon commented 7 years ago

I tried to update the Platform on this title: https://gokb.openlibraryfoundation.org/gokb/resource/show/org.gokb.cred.TitleInstancePackagePlatform%3A30666070

image

But got an error. Can you take a look?

https://gokb.openlibraryfoundation.org/gokb/resource/show/null%3Anull

image

ianibo commented 7 years ago

So - the intention, I believe, was that tipps must always be immutable - IE you can't update a platform on a tipp, you have to create a new tipp and retire the old one. We shouldn't ever have a situation where a tipp has no platform, as here - and the link is not an edit link, but a "follow" link. The error page is popping up because there is no platform. So - this isn't so much about editing platforms, as how the heck did we end up with a tipp that has no platform - that shouldn't happen. We need to dig in and see how many places this happens and see if we can figure out any pattern to it. Do you have any ideas as to why this particular one might not have a platform to begin with? @sosguthorpe do you have any thoughts?

jhsolomon commented 7 years ago

That makes sense!

I was adding a new title to the package based on the publisher's page, and I clicked add before I manually add the platform with it. I think this is a very small usecase, but it seems to me that no one should be allowed to manually add a title to a package without also indicating the platform.

On Tue, Feb 7, 2017 at 12:58 PM, Ian Ibbotson notifications@github.com wrote:

So - the intention, I belive, was that tipps must always be immutable - IE you can't update a platform on a tipp, you have to create a new tipp and retire the old one. We shouldn't ever have a situation where a tipp has no platform, as here - and the link is not an edit link, but a "follow" link. The error page is popping up because there is no platform. So - this isn't so much about editing platforms, as how the heck did we end up with a tipp that has no platform - that shouldn't happen. We need to dig in and see how many places this happens, and see if we can figure out any pattern to it. Do you have any ideas as to why this particular one might not have a platform to begin with? @sosguthorpe https://github.com/sosguthorpe do you have any thoughts?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/596#issuecomment-278085107, or mute the thread https://github.com/notifications/unsubscribe-auth/AMwAJTp_tXiKnOiwDc-7Hqhvkm4BG_B1ks5raLDcgaJpZM4L5wQZ .

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

ianibo commented 7 years ago

Duplicate of #518

jhsolomon commented 7 years ago

fix confirmed 3/2