search

k-john-gough / gpcp

Gardens Point Component Pascal is an implementation of the Component Pascal Language (CP). There are implementations for both the CLR and the JVM.
Other
59 stars 16 forks source link

Incorporate the changes from @pahihu to support Java 11 and Java 17 #22

Open 1997tn opened 1 year ago

1997tn commented 1 year ago

I'm very glad to see @k-john-gough still around and accepting pull requests. @pahihu didn't fork from this repo, he populated his repo with the source code from the released zip archive. This make doing a pull request to incorporate his changes to this repo more difficult. I attempted to do only to realize I don't understand Java and know nothing about gpcp's internals. Anyone still around please consider making a pull request to incorporate @pahihu's changes. Thank you very much.

@proberon Please have a look at https://github.com/pahihu/gpcp-JVM, there are only 9 commits, but I don't understand anything to help. I don't want myself to create a mess for you all.

p/s: This commit should be skipped: https://github.com/pahihu/gpcp-JVM/commit/116c8c861d877f0480b1bbff6ddef3dc2d77237a as that document has nothing to do with gpcp: https://github.com/pahihu/gpcp-JVM/issues/2

cfbsoftware commented 1 year ago

p/s: This commit should be skipped: pahihu/gpcp-JVM@116c8c8 as that document has nothing to do with gpcp: pahihu/gpcp-JVM#2

I disagree. The document gives additional information about the latest changes that were made to the CP language not a specific implementation of CP. On the contrary, it has much to do with GPCP as most, if not all, of those changes were implemented in GPCP.

1997tn commented 1 year ago

p/s: This commit should be skipped: pahihu/gpcp-JVM@116c8c8 as that document has nothing to do with gpcp: pahihu/gpcp-JVM#2

I disagree. The document gives additional information about the latest changes that were made to the CP language not a specific implementation of CP. On the contrary, it has much to do with GPCP as most, if not all, of those changes were implemented in GPCP.

I disagree with you. If the changes were already implemented, that document is OK. But the fact is they are not yet implemented, that document only causes confusion to the users.

cfbsoftware commented 1 year ago

I disagree with you. If the changes were already implemented, that document is OK. But the fact is they are not yet implemented, that document only causes confusion to the users.

Fact??? There seems to be some misunderstanding here. Which changes are you saying have not been implemented?

1997tn commented 1 year ago

I disagree with you. If the changes were already implemented, that document is OK. But the fact is they are not yet implemented, that document only causes confusion to the users.

Fact??? There seems to be some misunderstanding here. Which changes are you saying have not been implemented?

See: https://github.com/pahihu/gpcp-JVM/issues/2

That document is for another compiler. It doesn't apply to gpcp!

cfbsoftware commented 1 year ago

See: pahihu/gpcp-JVM#2

That document is for another compiler. It doesn't apply to gpcp!

pahihu/gpcp-JVM#2 has now been corrected at my request, confirming that the document does in fact apply to GPCP.

ghost commented 12 months ago

@proberon Could you make a PR for this? It seems you are an enthusiast.

pahihu commented 12 months ago

Hi,

Since my repo is not forked from the original, making a PR from it is a bit problematic. I have attached patch files, which contains the changes. Apply them in numerical order.

Regards, Andras Pahi

On 2023. Nov 24., at 10:10, tqo50396 @.***> wrote:

@proberon https://github.com/proberon Could you make a PR for this? It seems you are an enthusiast.

— Reply to this email directly, view it on GitHub https://github.com/k-john-gough/gpcp/issues/22#issuecomment-1825355286, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTEB2Y5NY6UH3SOH2ENPPDYGBP6RAVCNFSM6AAAAAATS65C2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVGM2TKMRYGY. You are receiving this because you were mentioned.

k-john-gough commented 11 months ago

Hi Chris

I have suddenly become aware of this discussion thread. I don’t really understand what the issues are, so perhaps you could find time to give me a short summary?

Regards John

From: Chris Burrows @.> Sent: Friday, January 6, 2023 11:26 PM To: k-john-gough/gpcp @.> Cc: K John Gough @.>; Mention @.> Subject: Re: [k-john-gough/gpcp] Incorporate the changes from @pahihu to support Java 11 and Java 17 (Issue #22)

p/s: This commit should be skipped: @.***https://github.com/pahihu/gpcp-JVM/commit/116c8c861d877f0480b1bbff6ddef3dc2d77237a as that document has nothing to do with gpcp: pahihu/gpcp-JVM#2https://github.com/pahihu/gpcp-JVM/issues/2

I disagree. The document gives additional information about the latest changes that were made to the CP language not a specific implementation of CP. On the contrary, it has much to do with GPCP as most, if not all, of those changes were implemented in GPCP.

— Reply to this email directly, view it on GitHubhttps://github.com/k-john-gough/gpcp/issues/22#issuecomment-1373622045, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEC5EFAUMAFGT3ZXH7QAKSTWRAMNVANCNFSM6AAAAAATS65C2E. You are receiving this because you were mentioned.Message ID: @.**@.>>

cfbsoftware commented 11 months ago

Hi John,

The part of this issue that you referred to is already closed:

https://github.com/pahihu/gpcp-JVM/issues/2

I am not familiar with the JVM version of GPCP so am unable to help with that part of this issue,

Cheers,

Chris

btreut commented 1 month ago

as far as I understand it, the patches created by Andras Pahi (aka pahihu) can be found here: https://github.com/pahihu/gpcp-JVM/tree/main/patches