k-monitor / parldata

MIT License
5 stars 1 forks source link

"empty" results – why? #15

Closed borbota closed 6 years ago

borbota commented 6 years ago

A testing user was unsure why the "empty" results are there (search term: "úny"):

uny_kereses

The first empty result leads here, where this text does not appear at all. It is quite confusing. I suppose in this case "úny" appears somewhere in the title of the discussed law or alike, however, this remains hidden for the user. Maybe for such "empty" results we shall add an explanatory sentence?

andraskalman commented 6 years ago

"Úny" is found in the bill_title field and it is provided among the highlights:

"highlight" : {
          "bill_title" : [
            "Szükséges és gazdaságos-e új karsztvíz kimélõ létesítése az Esztergom, Dorog, Sárisáp, Csolnok, Tokod, Tokodaltáró, Tát, Máriahalom, Mogyorósbámya, Dág, <em>Úny</em>, Leányvár, Kesztölc, Piliscsév településeket ellátó vízbázison?"
          ]
        }

I think the bill_title field should be displayed with the highlights as well if there is a hit in that specifiec field. Plus if there is no text field among the highlights the first 150-300 chars of the text field should be displayed as well. @borbota @kantord what do you think about this solution? These changes should be introduced in the UI. I can check if ES supports the highlight alternative field for the text (SOLR does) but I can't add the bill_title highlight to the displayed record from ES.

kantord commented 6 years ago

I agree, this should be introduced in the UI

kantord commented 6 years ago

see https://github.com/k-monitor/parliamentary_debates_open/issues/23

borbota commented 6 years ago

@andraskalman I agree, let's see how it looks like. Both the title and in case of no text highlight the first 150-300 chars of the text field.