search

k-monitor / parldata

MIT License
5 stars 1 forks source link

The frontend should call the suggestion endpoint instead of executing a search when typing the query #21

Closed andraskalman closed 5 years ago

andraskalman commented 5 years ago

Sometimes it is confusing when typing a query: search results are shown for the partial query phrase (which are absolutely not related with what I would like to search) then disappearing when typing a new character, then showing unrelated hits again after the next char and so on until the typing is finished. For example: start typing lázár

It would be better if the suggestion API endpoint would be called and some meaningful suggestions would be shown for the user to choose one to spare typing.

Endpoint documentation: https://github.com/k-monitor/parldata/tree/master/src/elasticsearch 3.6

andraskalman commented 5 years ago

This also renders access logs to be unusable, there are too much noise due to the searches during typing

kantord commented 5 years ago

Duplicate of https://github.com/k-monitor/parliamentary_debates_open/issues/4

I plan to implement this eventually, but I would argue that it's not the most pressing issue right now.

This also renders access logs to be unusable, there are too much noise due to the searches during typing

I wouldn't go as far to say that it makes them unusable, but it would certainly necessitate some noise filtering. However, if only full page reloads show up in the access logs anyway, then this issue should not happen.