search

k-takata / Onigmo

Onigmo is a regular expressions library forked from Oniguruma.
Other
617 stars 94 forks source link

Fix that onig_new() may crash #128

Closed k-takata closed 5 years ago

k-takata commented 5 years ago

When onig_reg_init() returns an error, onig_free_body() which is called via onig_new() may crash because some members are not properly initialized. Fix it.

codecov-io commented 5 years ago

Codecov Report

Merging #128 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #128      +/-   ##
=========================================
+ Coverage   82.68%   82.7%   +0.01%     
=========================================
  Files          63      63              
  Lines       12557   12558       +1     
=========================================
+ Hits        10383   10386       +3     
+ Misses       2174    2172       -2
Impacted Files Coverage Δ
regcomp.c 92.6% <100%> (+0.04%) :arrow_up:
regerror.c 86.53% <0%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e0f7ce...d2a090a. Read the comment docs.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.02%) to 80.763% when pulling d2a090a57e9445aa9d402a208f6d54feb8f3f28e on fix-onig_new-crash into 9e0f7ceee0c5182d2e930334ca9d298e69d389d9 on master.