search

k-takata / Onigmo

Onigmo is a regular expressions library forked from Oniguruma.
Other
626 stars 94 forks source link

Fix SEGV in onig_error_code_to_str() (Fix #132) #134

Closed k-takata closed 5 years ago

k-takata commented 5 years ago

When onig_new(ONIG_SYNTAX_PERL) fails with ONIGERR_INVALID_GROUP_NAME, onig_error_code_to_str() crashes. onig_scan_env_set_error_string() should have been used when returning ONIGERR_INVALID_GROUP_NAME.

codecov-io commented 5 years ago

Codecov Report

Merging #134 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #134      +/-   ##
=========================================
+ Coverage    82.7%   82.7%   +<.01%     
=========================================
  Files          63      63              
  Lines       12558   12561       +3     
=========================================
+ Hits        10386   10389       +3     
  Misses       2172    2172
Impacted Files Coverage Δ
regparse.c 90.57% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 595e086...00cc7e2. Read the comment docs.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.005%) to 80.769% when pulling 00cc7e28a3ed54b3b512ef3b58ea737a57acf1f9 on fix-segv-in-error-str into 595e086b7549ddc0ad9b582ab0ad6a1708d9bb9d on master.