k-takata / Onigmo

Onigmo is a regular expressions library forked from Oniguruma.
Other
617 stars 94 forks source link

Enable building Onigmo in WebAssembly for Opal-compatible regular expressions #153

Open ronaldtse opened 3 years ago

ronaldtse commented 3 years ago

This pull request enables building Onigmo in WebAssembly via WASI.

The changes it proposes are minimal and only specific to the WebAssembly build. This work is being used inside the opal-webassembly gem to enable regular expression compatibility in the browser and Opal-compiled Ruby. This was originally developed to allow Interscript rules to be run in the browser.

This is a contribution from Ribose Inc. Special thanks to @webdev778 for the great work.

codecov-io commented 3 years ago

Codecov Report

Merging #153 into master will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   82.86%   82.79%   -0.08%     
==========================================
  Files          63       63              
  Lines       12613    12646      +33     
==========================================
+ Hits        10452    10470      +18     
- Misses       2161     2176      +15     
Impacted Files Coverage Δ
regparse.c 91.48% <ø> (ø)
testc.c 96.03% <0.00%> (-1.90%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a06a42b...199c023. Read the comment docs.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 80.974% when pulling 199c02362b7e81e2294ddf1423fce4a0477b7926 on interscript:master into a06a42b51713eeafe30a939827031c3ba79da936 on k-takata:master.