search

k-talo / volatile-highlights.el

Minor mode for visual feedback on some operations in Emacs. STATUS: *STABLE*
135 stars 18 forks source link

Replace cl with cl-lib for emacs 27 #20

Closed takaxp closed 1 year ago

takaxp commented 4 years ago

Package cl is deprecated.

half-shell commented 3 years ago

This works for me on GNU Emacs 27.1. It gets rid of cl package being deprecated, an issue mentioned here and here, with a comment suggesting packages be updated to use cl-lib instead of cl.

@takaxp Is this still alive? Can we merge this or is there another supported repo that I am not aware of?

takaxp commented 3 years ago

Package cl is deprecated is still shown even if GNU Emacs 27.1 is used :(

stephan-cr commented 3 years ago

As @technician77 correctly points out, there's more work to do. All cl functions/macros have the cl- prefix in cl-lib. first needs to be cl-first. The same applies for second, third and probably many more. Right now it seems to work, because something else is loading cl.

The following functions need a prefix:

Furthermore, lexical-let needs to be replaced by something else.

pataquets commented 1 year ago

Looks like this PR is superceded by #22. If there's nothing else here, @takaxp: fancy to close this in favor of #22?