k-walter / pe

0 stars 0 forks source link

`CheatSheetList` should be responsible for `Storage`, not `UI` #12

Open k-walter opened 4 years ago

k-walter commented 4 years ago

As titled, it should not be the responsibility of UI to handle everything. For example, when CommandExecutor calls a method within CheatSheetList to edit an existing cheat sheet, Storage methods should be invoked within CheatSheetList to update if necessary.

nus-pe-bot commented 3 years ago

Team's Response

There are several operation that involves Storage class but does not involve CheatSheetList class, such as the Setting and the Favorite Command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In which case, it would be better if CheatSheetList, Setting and Favorite Command individually manage their Storage instances to reduce coupling.