search

k0001 / network-simple

Haskell library abstracting common network sockets usage patterns.
BSD 3-Clause "New" or "Revised" License
33 stars 9 forks source link

support for network-3.0.0.1 #30

Closed hdb3 closed 5 years ago

hdb3 commented 5 years ago

I looked at this upgrade to >= network-3.0.0.1 - there is no direct dependency here, but the socks library is problematic, partly because of the breakout of Network-BSD, but not only that. (socks relies on a PortID imported from Network, but neither Network nor PortID exist anymore.....) I resolved my requirement by removing the socks5 code and dependency in network-simple, however that might not suit others! I suspect that socks library will need to change for network-3.0......

hvr commented 5 years ago

For the record, I've fixed up the inaccurate metadata (see https://hackage.haskell.org/package/network-simple-0.4.3/revisions/) to prevent network-simple's build-plans from regressing today (see Based on https://matrix.hackage.haskell.org/package/network-simple@1555938426 )

k0001 commented 5 years ago

Dear Herbert, thanks for letting me know.

I will upload a new compatible version as soon as the 'socks' library is updates.

On Mon, Apr 22, 2019, 16:24 Herbert Valerio Riedel notifications@github.com wrote:

For the record, I've fixed up the inaccurate metadata (see https://hackage.haskell.org/package/network-simple-0.4.3/revisions/) to prevent network-simple's build-plans from regressing today (see Based on https://matrix.hackage.haskell.org/package/network-simple@1555938426 )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/k0001/network-simple/issues/30#issuecomment-485417374, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAAZZRTMPA33J3PWBLEHPTPRW4APANCNFSM4GUWJ7DA .

shulhi commented 5 years ago

@k0001 I have a working version that is compatible with network > 3, you can see the diff here https://github.com/k0001/network-simple/compare/master...plow-technologies:shulhi-update-network-socks

I like to PR this since we are using this at work. If you think the changes are okay, I can make a PR with what I have (or with necessary changes)

k0001 commented 5 years ago

network-simple-0.4.4 has been uploaded to hackage, and is now compatible with the newest version of socks. Thanks!

k0001 commented 5 years ago

@shulhi I just noticed your comment offering your changes and a PR. Sorry, I missed it before, but I am nonetheless very thankful for your offer :)

hvr commented 5 years ago

@k0001 the latest network-simple-0.4.4 release doesn't seem to be compatible, see https://matrix.hackage.haskell.org/package/network-simple@1559983336

k0001 commented 5 years ago

Thanks for letting me know!

On Sat, Jun 8, 2019, 19:14 Herbert Valerio Riedel notifications@github.com wrote:

@k0001 https://github.com/k0001 the latest network-simple-0.4.4 release doesn't seem to be compatible, see https://matrix.hackage.haskell.org/package/network-simple@1559983336

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/k0001/network-simple/issues/30?email_source=notifications&email_token=AAAAZZTZFD76N77XDNC7BQ3PZPLETA5CNFSM4GUWJ7DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHXUQQ#issuecomment-500136514, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAAZZVEIIXHNH67PYDA2FDPZPLETANCNFSM4GUWJ7DA .