Closed jasagredo closed 5 years ago
@Jasagredo thanks for this! However, we need to support some previous versions of network
, since they are still in widespread use. I think following the advice in https://hackage.haskell.org/package/network-bsd-2.8.1.0 is a sensible choice. That is:
network (>=2.7)
network-bsd (>=2.7)
I'm perfectly okey with that constraints. If you tell me if something else is needed (the nix part is obscure for me) I'll gladly fix the PR.
That should be fine. I'll merge it as soon as you submit those changes, and I'll try building here with different network
versions just in case. Thanks!!!
Ready to merge.
Thanks! I'll upload this to Hackage as soon as successfully build it here with different network
versions.
As stated in their hackage description:
Therefore, the dependency on
network (>=2.3)
is way too relaxed. This leads to failing builds as just happened to me:This PR updates de dependencies to support the package split.
Also, as I'm not a user of Nix, I have no idea if any other changes are required. Maybe add
network-bsd
topkg.nix
.