k0001 / network-simple

Haskell library abstracting common network sockets usage patterns.
BSD 3-Clause "New" or "Revised" License
33 stars 9 forks source link

New release? #32

Closed erikd closed 5 years ago

erikd commented 5 years ago

I am running into this:

src/Network/Simple/Internal.hs:24:1: error:
    Could not load module ‘Network.BSD’
    It is a member of the hidden package ‘network-bsd-2.8.1.0’.
    Perhaps you need to add ‘network-bsd’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘network-2.8.0.1’.
    Perhaps you need to add ‘network’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘network-2.8.0.1’.
    Perhaps you need to add ‘network’ to the build-depends in your .cabal file.
    Use -v to see a list of the files searched for.
   |
24 | import qualified Network.BSD as NS (getServicePortNumber)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

which seems to be fixed in git.

erikd commented 5 years ago

I am currently using the following in my cabal.project file.

source-repository-package
  type: git
  location: https://github.com/k0001/network-simple
  tag: db274d137fc92dd32aff32ecae025060ccb1d7f7
k0001 commented 5 years ago

Hey @erikd, thanks for this.

I haven't uploaded this yet because I haven't had the time to check that this is building with various network versions, and update the Nix builds accordingly. Sorry. I'll do it as soon as possible.

erikd commented 5 years ago

Easiest way to make sure its building with multiple GHC versions is to do so in CI.

Interested in a patch to the travis setup for that?

k0001 commented 5 years ago

There was a CI, but I haven't kept it up to date. I'll add different configurations to the nix setup as soon as possible and make sure the CI uses that. Thanks!

On Thu, Jun 13, 2019, 00:53 Erik de Castro Lopo notifications@github.com wrote:

Easiest way to make sure its building with multiple GHC versions is to do so in CI.

Interested in a patch to the travis setup for that?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/k0001/network-simple/issues/32?email_source=notifications&email_token=AAAAZZXEGUOAIZVLIEGSN3LP2FV6ZA5CNFSM4HXSDU22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXR463Q#issuecomment-501469038, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAAZZWLV57UXW4GBDOX6BLP2FV6ZANCNFSM4HXSDU2Q .

erikd commented 5 years ago

I have a 30 line .travis.yaml script that runs in just about any Haskell project and tests with multiple compilers. Will take me under a minute to raise the PR if you want it.

k0001 commented 5 years ago

Alright, let's do it! Thanks.

On Thu, Jun 13, 2019, 00:58 Erik de Castro Lopo notifications@github.com wrote:

I have a 30 line .travis.yaml script that runs in just about any Haskell project and tests with multiple compilers. Will take me under a minute to raise the PR if you want it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/k0001/network-simple/issues/32?email_source=notifications&email_token=AAAAZZUSJXSN5VOEYZL4QQ3P2FWRJA5CNFSM4HXSDU22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXR5JQQ#issuecomment-501470402, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAAZZW35Q2HH4ZA3SYE3ATP2FWRJANCNFSM4HXSDU2Q .

k0001 commented 5 years ago

Done! Thanks @erikd!!

https://hackage.haskell.org/package/network-simple-0.4.5

erikd commented 5 years ago

:100:

erikd commented 5 years ago

And don't forget to push your local changes to github :).

k0001 commented 5 years ago

Done :) thanks for the reminder. It's been a long day.

On Thu, Jun 13, 2019, 02:00 Erik de Castro Lopo notifications@github.com wrote:

And don't forget to push your local changes to github :).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/k0001/network-simple/issues/32?email_source=notifications&email_token=AAAAZZWE7LMLFXKJE7B7K5LP2F5YZA5CNFSM4HXSDU22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSA26Q#issuecomment-501484922, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAAZZT2WXKZTTYXIST4ERDP2F5YZANCNFSM4HXSDU2Q .