Closed abhi1693 closed 1 year ago
@k01ek Can you please review this?
@k01ek Can this be merged and released? We are waiting for this to become official to add to our production deployment
@abhi1693 Sorry for delay. I think this plugin should not have two different pages for device types and module types and should be as simple as possible. In my opinion, it's enough to add column to table which can show is it module-type or device-type, and maybe modify filterform and filterset...
@abhi1693 Sorry for delay. I think this plugin should not have two different pages for device types and module types and should be as simple as possible. In my opinion, it's enough to add column to table which can show is it module-type or device-type, and maybe modify filterform and filterset...
I did try that and realised people will have a lot more timeouts with a single page when more modules are added to the repo. Along with that, there are several more changes that are needed not just in filter form and filterset like determining the return URLs are import whether to open module page or device page, figure out which form to open based on the types and other changes to keep try and keep things in sync.
Ok, I got it. Give me a couple of days. I am gonna test this, and do some fixes..
@k01ek Any ETA on this PR?
@k01ek Have you checked this yet?
@k01ek Ping
device-types
andmodule-types
utilities.py
togql.py
due to conflicts with theutilities
module in the core project