search

k06a / boolinq

Simplest C++ header-only LINQ template library
MIT License
628 stars 79 forks source link

Coverage needs to be fixed #52

Closed k06a closed 2 years ago

k06a commented 2 years ago

Figure out why it is not working anymore and fix it in a separate PR.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.03 ETH (113.42 USD @ $3780.64/ETH) attached to it.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 264 years, 10 months from now. Please review their action plans below:

1) helr441 has been approved to start work.

My action plan:

A quick glance (at Travis CI build matrix and Coverall stats) preliminarily suggests that it's a Coveralls back-end change, perhaps 0% coverage from one build flavour (Clang) has a ripple effect and wipes out the 90%-100% coverage from the other g++ builds. Probably try finding out some Clang flags to get it to emit gcov-compatible coverage output.

Learn more on the Gitcoin Issue Details page.

helr441 commented 2 years ago

Thanks @k06a. It looks like clang/llvm is emitting the coverage, but the coverage data is mangled - or at least, not recognised by cpp-coveralls, the Coveralls integration for C/C++ Coverage..

k06a commented 2 years ago

@helr441 I don't know why this is happening. I remember I was working fine previously (meanwhile it was a while ago).

helr441 commented 2 years ago

Yeah really strange, if you examine the commit history and Travis CI builds/Coverall builds, the commit that caused the sudden jump from 90-100% to 0% had no CI/config related changes. Not sure what happened, perhaps Coveralls changed their coverage computation so that a single 0% just wipes out the 90-100% coverage from the other builds.

While we can't change Coverall's backend code/computation, we can try fixing clang coverage (cpp-coveralls seems to segfault).

This is the approach of #57 .

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.03 ETH (111.98 USD @ $3732.51/ETH) has been submitted by:

  1. @helr441

@k06a please take a look at the submitted work:

k06a commented 2 years ago

Thanks @helr441!

k06a commented 2 years ago

It seems coverage returned to 0% again.

helr441 commented 2 years ago

Seems one of the CMakeFile changes lost the coverage data (.gcno file), take a look at #60 .

k06a commented 2 years ago

@helr441 thank you!

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.03 ETH (112.61 USD @ $3753.64/ETH) attached to this issue has been approved & issued to @helr441.