search

k06a / boolinq

Simplest C++ header-only LINQ template library
MIT License
628 stars 79 forks source link

Configure one of the tests to use C++14 #59

Closed nargeslein closed 2 years ago

nargeslein commented 2 years ago

Hi @k06a, I have addressed issue #54 by creating a separate test target which requires C++14 and changes to the CMake files. In addition I have added a comment in the README.

I hope this addresses the issue as you had expected and I am looking forward to further contributions. It was really interesting to work on this so far.

k06a commented 2 years ago

Hi @nargeslein! Thanks for the contribution. I wonder why CI was not even started for this PR…

k06a commented 2 years ago

@nargeslein please use branch with name other than master next time, it will be much more convenient 👍

nargeslein commented 2 years ago

@nargeslein please use branch with name other than master next time, it will be much more convenient +1

Hi @k06a many thanks for the feedback. I will use a branch next time. Do you have an idea/suggestion for the naming?

k06a commented 2 years ago

Use something like this next time.

feature/cpp14-test
test/cpp14

This time I will merge it once we will fix CI issues :)

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 54e31bd6f024ea14ba92961e10e067bb91f467c9 on nargeslein:master into 3ce25a7f69704df06ccde761536c9f00411d53e3 on k06a:master.

nargeslein commented 2 years ago

Use something like this next time.

feature/cpp14-test
test/cpp14

This time I will merge it once we will fix CI issues :)

I have renamed the branch 'master' to 'feature/cpp14-test' in any case but not sure if it will be picked up in this PR