search

k0kubun / hamlit

High Performance Haml Implementation
https://rubygems.org/gems/hamlit
Other
981 stars 59 forks source link

Fix requires for sandboxed bundler setup #133

Closed yb66 closed 5 years ago

yb66 commented 5 years ago

Good day,

I was trying to work on adding in one of the Haml helpers I wanted but I had problems because I used bundle install --binstubs --path=vendor.noindex and that fired back lots of errors about require when I ran the tests, so I made the changes here.

Even if you're not sandboxing the project I think the changes help by clarifying where the C extension is being required and where it is not, and by keeping generated executables separate from the project's own code (bin vs exe).

Regards, iain

k0kubun commented 5 years ago
  1. DO NOT delete bin/* utils. They are necessary. Just deleting them is never acceptable.
  2. Avoid unnecessarily changing coding styles; changing single quotes to double quotes, having extra .rb

1 is not acceptable and every line of 2 will be changed for the above reason. So closing but I accept having a change for 2 and will fix it. Thanks.

k0kubun commented 5 years ago

Even if you're not sandboxing the project I think the changes help by clarifying where the C extension is being required and where it is not,

Oh, I guess one of the reason you explicitly added .rb is for clarifying it's not .so file.

I really appreciate your effort on making the bundler binstub of Hamlit and some of your proposals about the error reporting make sense. But I, as the only maintainer of this project, feel comfortable for choosing the the defacto-standard way of writing Ruby code for rubygems.

So, please suggest updating the default gem template created by bundle gem to https://github.com/bundler/bundler/issues/new, and come to here again once it becomes the default code of bundle gem templates (I'm neutral about them and not interested in proposing it by myself, but will follow the changes of Bundler's templates). Thank you.