Tests failure

[utkarsh2102]

Hi,

There seem to be some test failures. Here are the logs:

Finished in 3.419018s, 124.0122 runs/s, 126.0596 assertions/s.

  1) Failure:
UglyTest::Basichamltagsandcss#test_multiple_simple_Haml_tags [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:307]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
 "<div>
-  <div>
-    <p></p>
-  </div>
+<div>
+<p></p>
+</div>
 </div>
 "

  2) Failure:
UglyTest::Markupcomments#test_a_nested_markup_comment [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:807]:
--- expected
+++ actual
@@ -1,5 +1,5 @@
 "<!--
-  comment
-  comment2
+comment
+comment2
 -->
 "

  3) Failure:
UglyTest::Tagswithnestedcontent#test_Nested_content_multiple_simple_tags [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:476]:
--- expected
+++ actual
@@ -1,8 +1,8 @@
 "<div>
-  <div>
-    <p>
-      text
-    </p>
-  </div>
+<div>
+<p>
+text
+</p>
+</div>
 </div>
 "

  4) Failure:
UglyTest::Tagswithnestedcontent#test_Nested_content_simple_tag [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:444]:
--- expected
+++ actual
@@ -1,4 +1,4 @@
 "<p>
-  hello
+hello
 </p>
 "

  5) Failure:
UglyTest::Tagswithnestedcontent#test_Nested_content_tag_with_CSS [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:457]:
--- expected
+++ actual
@@ -1,4 +1,4 @@
 "<p class='class1'>
-  hello
+hello
 </p>
 "

  6) Failure:
UglyTest::Whitespaceremoval#test_a_tag_with_appended_and_nested_content [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:1094]:
--- expected
+++ actual
@@ -1,4 +1,4 @@
 "<li>hello</li><li>
-  world
+world
 </li><li>again</li>
 "

  7) Failure:
UglyTest::Conditionalcomments#test_a_conditional_comment [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:822]:
--- expected
+++ actual
@@ -1,4 +1,4 @@
 "<!--[if IE]>
-  <p>a</p>
+<p>a</p>
 <![endif]-->
 "

  8) Failure:
UglyTest::Tagswithinlinecontent#test_Inline_content_multiple_simple_tags [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:429]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
 "<div>
-  <div>
-    <p>text</p>
-  </div>
+<div>
+<p>text</p>
+</div>
 </div>
 "

  9) Skipped:
UglyTest::Tagswithhtmlstyleattributes#test_HTML_style_tag_with_an_atomic_attribute [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:593]:
[INCOMPATIBILITY] Hamlit limits boolean attributes

 10) Failure:
UglyTest::Rubystyleinterpolation#test_interpolation_inside_filtered_content [/tmp/autopkgtest-lxc.s57iq6eq/downtmp/build.hT6/src/test/haml/haml-spec/ugly_test.rb:972]:
--- expected
+++ actual
@@ -1,2 +1,3 @@
 "value interpolated: value
+
 "

424 runs, 431 assertions, 9 failures, 0 errors, 1 skips
rake aborted!

[utkarsh2102]

For complete logs, check: https://ci.debian.net/data/autopkgtest/testing/amd64/r/ruby-hamlit/1804497/log.gz

Can these be fixed at the earliest?

[k0kubun]

• These tests are comparing Haml 5's behavior and Hamlit's behavior.
  • Old Haml (until version 4) had 2 modes: "ugly" and "pretty", and Haml 5 has only "ugly" mode.
  • Hamlit is intended to be compatible with Haml's "ugly" mode.
• You're installing ruby-haml 4.0.7, and the test is failing because of your Haml version.
• This means that nothing of Hamlit needs to be fixed. You somehow need to make sure Haml 5+ is installed on your environment.

[k0kubun]

Well, but as we're declaring Haml as development dependency, we might want to restrict Haml version in the development dependency. Let me fix that to prevent this kind of issues.

[k0kubun]

Okay, I modified development dependency on master branch (not released yet) so that it requires Haml 5 for testing Hamlit.