search

k0kubun / hamlit

High Performance Haml Implementation
https://rubygems.org/gems/hamlit
Other
981 stars 59 forks source link

Treat string literals as frozen #162

Closed aliismayilov closed 4 years ago

aliismayilov commented 4 years ago

Once this PR is merged, it should be "safe" to use this gem in a project with "RUBYOPT=--enable-frozen-string-literal", where the strings will be treated as frozen literals by default.

k0kubun commented 4 years ago

To resolve most of the above problems without waiting for haml-parser.gem, I can work on automating Haml parser/test synchronization to this repository, which should be done regardless of this PR.

If you agree with the above comments, I can take over this work from you. Please let me know if you like it.

aliismayilov commented 4 years ago

To resolve most of the above problems without waiting for haml-parser.gem, I can work on automating Haml parser/test synchronization to this repository, which should be done regardless of this PR.

If you agree with the above comments, I can take over this work from you. Please let me know if you like it.

Yep, I agree with the comments. Feel free to take over :)

k0kubun commented 4 years ago

I completed the automation at https://github.com/k0kubun/hamlit/pull/163 and added a minor modification to this branch. Now it's ready to be merged. Thank you!