search

k0kubun / hamlit

High Performance Haml Implementation
https://rubygems.org/gems/hamlit
Other
980 stars 60 forks source link

Add test for GC.compact #179

Closed stanhu closed 2 years ago

stanhu commented 3 years ago

This would have detected #177 and #171 in Ruby 3.0.

stanhu commented 3 years ago

Hmm, I wonder if these test failures are legitimate. This one looks like an issue:

Error:
TemplateTest#test_template_should_render_correctly [template: helpful]:
NotImplementedError: method `parse' called on unexpected T_IMEMO object (0x000056322fd20048 flags=0x1301a)
    /home/stanhu/github/hamlit/test/haml/templates/helpful.haml:1:in `build'
    /home/stanhu/github/hamlit/test/haml/templates/helpful.haml:1:in `_home_stanhu_github_hamlit_test_haml_templates_helpful_haml___355773193740528534_4340'
    /home/stanhu/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/actionview-6.1.3/lib/action_view/base.rb:247:in `public_send'
k0kubun commented 3 years ago

GC.compact itself could still have an issue. Unlike #171 and #177, I'm not sure if it's a fault of Hamlit at this point. At least the reproduction code should be smaller if you want to investigate it, and I cannot merge this until we fix the CI failure.

k0kubun commented 2 years ago

Let me close this until this PR becomes actionable on my end. Thank you.