k0kubun / hamlit

High Performance Haml Implementation
https://rubygems.org/gems/hamlit
Other
981 stars 59 forks source link

SCSS filter not working with sass-embedded #195

Closed willcosgrove closed 2 years ago

willcosgrove commented 2 years ago

sass-embedded returns a frozen string, and hamlit expects to be able to modify the return output of Tilt::Template#render

https://github.com/k0kubun/hamlit/blob/aea5ae1da6456d5579b5734d38ea25ccbf12d1f0/lib/hamlit/filters/tilt_base.rb#L7-L11

I don't know where the appropriate place is to open an issue. Tilt is the one that has changed the API contract by returning a frozen string. @ntkme, I know you chose to use a frozen string output from sass-embedded for performance reasons. Do you have any feedback on where the appropriate place is to fix this issue?