k0kubun / hamlit

High Performance Haml Implementation
https://rubygems.org/gems/hamlit
Other
981 stars 59 forks source link

master build fail #74

Closed mibamur closed 8 years ago

mibamur commented 8 years ago

ruby 2.3.1 OS X

Using hamlit 2.5.0 from git://github.com/k0kubun/hamlit.git (at master@0249bbd)

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /Users/user/.rvm/gems/ruby-2.3.1@rails5/bundler/gems/hamlit-0249bbd55cc1/ext/hamlit
/Users/user/.rvm/rubies/ruby-2.3.1/bin/ruby -r ./siteconf20160628-68069-p25u8j.rb extconf.rb
creating Makefile

current directory: /Users/user/.rvm/gems/ruby-2.3.1@rails5/bundler/gems/hamlit-0249bbd55cc1/ext/hamlit
make "DESTDIR=" clean

current directory: /Users/user/.rvm/gems/ruby-2.3.1@rails5/bundler/gems/hamlit-0249bbd55cc1/ext/hamlit
make "DESTDIR="
compiling hamlit.c
hamlit.c:3:10: fatal error: 'houdini.h' file not found
#include "houdini.h"
         ^
1 error generated.
make: *** [hamlit.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/user/.rvm/gems/ruby-2.3.1@rails5/bundler/gems/hamlit-0249bbd55cc1 for inspection.
Results logged to /Users/user/.rvm/gems/ruby-2.3.1@rails5/bundler/gems/extensions/x86_64-darwin-15/2.3.0/hamlit-0249bbd55cc1/gem_make.out

An error occurred while installing hamlit (2.5.0), and Bundler cannot continue.
mibamur commented 8 years ago

But

gem 'hamlit'#, github: 'k0kubun/hamlit'

Ok

k0kubun commented 8 years ago

The file "houdini.h" is included in Hamlit repository by git submodule. Please try git submodule init && git submodule update or git clone --recursive.

hanachin commented 8 years ago

Add a submodules option to gem directive could help.

gem 'hamlit', github: 'k0kubun/hamlit', submodules: true

submodules Specify :submodules => true to cause bundler to expand any submodules included in the git repository http://bundler.io/v1.10/man/gemfile.5.html

k0kubun commented 8 years ago

Opps, that's true. I mistook the case since I usually work with Hamlit specifying the location by not github but path option.

mibamur commented 8 years ago

@hanachin thanks @k0kubun should we change README.md to ?

gem 'hamlit', github: 'k0kubun/hamlit', submodules: true