search

k0kubun / hamlit

High Performance Haml Implementation
https://rubygems.org/gems/hamlit
Other
981 stars 59 forks source link

include tests in gem file #79

Closed pravi closed 8 years ago

pravi commented 8 years ago

I'm packaging hamlit for debian and would like to have tests enabled when creating the deb file. We usually take the github tarballs directly, but its missing houdini. So we have to manually recreate a source tarball that both houdini and tests.

k0kubun commented 8 years ago

Thank you for your effort of packaging Hamlit.

Tests are in the repository and should be in "github tarballs". Do you mean you want Hamlit to stop using git submodule of houdini and copy it?

pravi commented 8 years ago

@k0kubun it would be easier if you just add 'test' in gem releases. Copying houdini will also work.

k0kubun commented 8 years ago

if you just add 'test' in gem releases

Actually tests are excluded from rubygems package. https://github.com/k0kubun/hamlit/blob/v2.5.0/hamlit.gemspec#L17

Excluding tests is (bundler template's) default config and including tests increases the size of package. I'm reluctant to do that.

Copying houdini will also work.

Hmm... I confirmed that tarball does not have neither houdini nor .git. Git submodule is harmful in some ways, so personally I'm okay to do this. I'll do that later. For now, I recommend you to manually download houdini and extract it to ext/hamlit/houdini since I think it's responsibility of not Hamlit but packaging.

k0kubun commented 8 years ago

Ah, maybe we can add tarball that has houdini to releases to each release automatically. Since it's not default, I need research how to do it.

k0kubun commented 8 years ago

Dropped git submodule of houdini in https://github.com/k0kubun/hamlit/pull/82. So closing for now. Feel free to reopen this if you still have a problem.