k0lter / autopostgresqlbackup

Automated tool to make periodic backups of PostgreSQL databases
52 stars 17 forks source link

Update autopostgresqlbackup and include DBPORT in all definitions #30

Closed dlage closed 5 months ago

dlage commented 6 months ago

Use DBPORT even for localhost connections. Example of needed usage: backup a specific database from localhost server when running multiple postgres instances in the same server.

Let me know if there's some issue with this approach.

Regards, Dinis

k0lter commented 5 months ago

Hi @dlage

I understand the issue you're pointing here about multiples instances on the same host. However, I still want to use the socket connection (not the TCP one) in that case.

I've commited a fix which should address this: https://github.com/k0lter/autopostgresqlbackup/commit/30e760454c634cdd33bac55d0e57d27bdcb99647

Tell me if it's ok.

dlage commented 5 months ago

Hi @k0lter,

Thank you for taking a look at this, I'll try to test it later today and get back to you.

dlage commented 5 months ago

Hi @k0lter, I was just able to confirm that your fix was indeed a better approach to the issue. Thank you for that! I'm closing this PR then.