Need test class for the class - FindHttpBasicAuthFinder.

k0r0pt / Project-Tauro

A Router WiFi key recovery/cracking tool with a twist.

GNU General Public License v3.0

89 stars 16 forks source link

Need test class for the class - FindHttpBasicAuthFinder. #11

Open sudiptosarkar opened 7 years ago

sudiptosarkar commented 7 years ago

Yes, I know the class name needs refactor. We need a test class made for this class. Tests should not make real calls. Instead, calls must be mocked with Mockito and/or PowerMockito. Examples of the testing pattern can be found in the other three dependency repos mentioned in the README.md.

cyterdan commented 7 years ago

Hi !

I'd like to start working on this.

sudiptosarkar commented 7 years ago

@cyterdan Sure... Go ahead. Raise a Pull Request when you're done and put me on review... 🙂

cyterdan commented 7 years ago

Seems there is an infinite loop when google is not reachable, is that by design ?

sudiptosarkar commented 7 years ago

@cyterdan Yes. That's for resiliency. If the attacking system's Internet goes down, it will wait till it's back up... Also because my Internet connection sucked when I wrote it... :smiley: