search

k0rventen / avea

Control Elgato's Avea bulb using python3 !
MIT License
8 stars 1 forks source link

Start using flake8 #12

Open pattyland opened 4 years ago

pattyland commented 4 years ago

This is just a suggestion: In other python projects I am involved in, the use of Flake8 for linting is often required. I have already reformatted a lot, but flake still complains a lot... If you don't want that or prefer another linter, that's no problem!

pattyland commented 4 years ago

Wow, automated building and testing with Travis CI, that wasn't there yesterday? Awesome!

k0rventen commented 3 years ago

Yeah when I started the project I didn't knew about linting, nowadays I use mostly autopep8, but flake8 is fine too. You're right, it should be applied to this project. I'll check locally this weekend I hope, and push the changes.

Regarding CI, I've enabled it after merging your commits yesterday, I was tired of manually building and pushing to pypi. So now it's all automated through GitHub actions ! when a release is created, it'll build and push the new version on pypi. Quite cool I think :D

k0rventen commented 3 years ago

Some update on the use of flake8, I'm setting up an automated GitHub action for it so that it can check automatically before publishing if everything is fine.