search

k0shk0sh / FastHub

FastHub the ultimate GitHub client for Android.
GNU General Public License v3.0
5.71k stars 931 forks source link

Last releases lack APK attachment #1208

Closed IzzySoft closed 6 years ago

IzzySoft commented 6 years ago

Checking my logs I just noticed that the last 2 releases had no .apk file attached (so my repo couldn't update it). Just forgotten, or is this intentional? The promising black box on the README.md saying "Direct APK download" is currently misleading (going to "latest" where there is no .apk) :wink:

yakov116 commented 6 years ago

@IzzySoft Yes.

You can get it from XDA

k0shk0sh commented 6 years ago

I'll try and upload it later.

yakov116 commented 6 years ago

@IzzySoft done!

IzzySoft commented 6 years ago

@yakov116 XDA doesn't work with my auto-updater, sorry. But the newly attached file does work with it: update fetched, "upsync" started, find it here in a few minutes :wink: Thanks!

IzzySoft commented 6 years ago

@yakov116 @k0shk0sh unfortunately, the latest releases miss the APK again. Could you please continue attaching it? Starting with the most recent one will suffice.

yakov116 commented 6 years ago

@IzzySoft sure will do it in a few

IzzySoft commented 6 years ago

@yakov116 please add a small unit: hours would be fine, minutes superb – months or even years would be shocking :fearful:

yakov116 commented 6 years ago

@IzzySoft sorry got very busy. Will do it later tonight

yakov116 commented 6 years ago

@IzzySoft done

k0shk0sh commented 6 years ago

Honestly I shouldn't upload the apk anymore since its already in foss. Is there another reason that I should upload it?

IzzySoft commented 6 years ago

@yakov116 Thanks! Fetched & updated in the repo (currently syncing).

@k0shk0sh Is it already on the main repo? I only see it in Archive, with a last release of 2017-05-10.

k0shk0sh commented 6 years ago

It was @yakov116 who uploaded it. The thanks should go to him ;),

IzzySoft commented 6 years ago

@k0shk0sh Yepp, just noticed: I've got the notification for @yakov116's post, and when writing the answer yours was the last – got me confuse (not really awake yet). So what do you mean by "its already in foss"? As I wrote, I just checked and it's on F-Droid Archive in an older version only. It's not in the main repo as far as I can see.

IzzySoft commented 6 years ago

Ahem, shall we keep this issue open? v4.6.0 lacks the .apk again :scream:

IzzySoft commented 6 years ago

@k0shk0sh v4.6.1 as well lacks the APK. Did you give up on it? Shall I remove it from my repo? We don't want the users to stick with old versions, do we?

yakov116 commented 6 years ago

@IzzySoft apkmirror...

IzzySoft commented 6 years ago

@yakov116 if that's the final say, I'll have to remove the app from my F-Droid repo. Can't update it from there, sorry. So will you confirm? Or deny?

yakov116 commented 6 years ago

@IzzySoft why it's the exact same apk!

IzzySoft commented 6 years ago

@yakov116 that might be. But it's a different server and structure. My auto-updater doesn't know how to handle it. And I don't have the time to program all possibilities to scrape the APK data out of different HTML structures.

My script can deal with Github releases, with the APK inside the repo, and with the APK having a "fixed URL" (e.g. http://example.com/latest.apk). Not with Playstore, APKMirror etc. Not with changing links on pages other than Github releases/repo (http://example.com/app_v1.2.3.apk which next time is app_v1.2.5.apk) where I don't know what to look for.

You say APKMirror, other projects say Dropbox, Mega, our CI Build server … Sorry, but I cannot effort to deal with all those. I do my best to provide some additional service – but I'm only a single person with limited resources. And I've got some other work to do for living (unfortunately). So I hope you can understand why I say "Can't update it from there". And if I can't update it, I can't provide it in my repo: users would rightfully blame me for outdated versions.

No bad feelings: you do that in your spare time as well, and you have to budget your time as I have – so we're sitting in "comparable boats" (not necessarily the same boat :wink:). So let's see where we can meet: Can you maintain your .apk here at Github, or provide it via a "fixed URL" some place? Then I can pick it and provide it via my repo. If you can't, I say thank you for your good and well appreciated support in the past, but I have to remove your app from my repo and we "part" as friends. All must be fair for both sides: We each must respect each others "budget"/limits.

MartinX3 commented 6 years ago

why don't you use travis CI and the github graph api? and with "you" I don't mean a specific person.

yakov116 commented 6 years ago

@MartinX3 for building the apk??? What are you talking about?

k0shk0sh commented 6 years ago

@IzzySoft I literally was thinking of dropping that support because of my experience with FOS users, and I bet you know the story and everything (as I have seen you involving in some conversations) but you were here since the beginning and I don't easily forget those who gave hands.

@yakov116 could you please proceed with uploading the APK as you usually do into the release when you have time? I know i'm asking for too much, but honestly I have no time right now to do that.

yakov116 commented 6 years ago

@k0shk0sh sure. Actually it would be much easier for me if I would be able to do it from the app :stuck_out_tongue_closed_eyes::sunglasses:

MartinX3 commented 6 years ago

@yakov116

"for building the apk???"

I don't know, why you are using so many "???", but yes.

"What are you talking about?"

About building the APK's with travis. You read the same conversation like me, or didn't you and live on another planet? https://github.com/harmittaa/travis-example-android

yakov116 commented 6 years ago

@MartinX3 we got messed up in the past when trying to do this PLUS it would require @k0shk0sh to set it up with his key

MartinX3 commented 6 years ago

@yakov116 When he set it up with his key, it is done and will work on every release automatically.

But what you you mean with "messed up"? May I help you somehow?

yakov116 commented 6 years ago

@yakov116 When he set it up with his key, it is done and will work on every release automatically. But what you you mean with "messed up"? May I help you somehow?

Ok lets give a little background on how the repo is setup. By default the repo is building a debug build ( for reasons I have no time to explain). By uing travis to build the apk 2 things would happen.

  1. The builds would be debug build and have a different key
  2. The pro features would be enabled and there would be a loss for @k0shk0sh
MartinX3 commented 6 years ago

@yakov116 Of course are debug builds important to test the software and of course should be everything enabled, if you run a debug build, to test everything.

But of course you can set up travisCI to build release and/or debug builds with different keys each, if you want. Other projects did that successful, so with some reading and understanding it would work too in this project and will save your important time.

https://docs.travis-ci.com/user/deployment/releases

yakov116 commented 6 years ago

@MartinX3 please read what i wrote.

By default the repo is building a debug build ( for reasons I have no time to explain).

Im not saying it not possible but its not an option at this point

Lets put it simple, why in the world would we put time into this now? For one person to get just the apk? not worth the time and effort

MartinX3 commented 6 years ago

@yakov116 It's okay if you don't want the service of a CI, like travisCI will give you.

And it is not only ONE person. The automatically build APK can be placed everywhere github, apkmirror, google playsotre, f-droid, etc. It is a time saving investment.

yakov116 commented 6 years ago

@MartinX3 OK lets not fight over this. I cant link you to where we had a whole discussion since it was a private one.

In other news the apk was uploaded

@IzzySoft I will try to upload the APK from now on

MartinX3 commented 6 years ago

@yakov116 If you need some help in the future to implement this, I would be happy to help you. :)

IzzySoft commented 6 years ago

@k0shk0sh Thanks!

@yakov116

For one person to get just the apk?

You really believe I'm the only one using my repo (which is for what my updater grabs your APKs, and those of 350+ other projects) :smile: To give you some numbers: Avg daily hits 100k+, avg daily visits 10k+, monthly throughput ~60GB (i.e. roughly 2GB per day). In 12/2017, there were 106 downloads of the Fasthub APK via my repo for v4.5.7, plus 6 for v4.5.1, plus 1 for v4.4.2 – which suggests there are more than 10 or 20 users behind it (why should one load the same version multiple times); as use of the repo is anonymous (and I'm not using any tracking on my sites), I cannot give any numbers on "real users" or "installations".

As @MartinX3 pointed out, having an integrated CI has many advantages: while the first-time setup might not be easy (I cannot tell, never having done that), it not only could place the files on a release, but also tell you at each commit if you broke something, plus give your testers "nightly builds" if you wish so. Not saying you have to use CI – but agreeing that would be a "once done it's done, just benefit then" thing.

I will try to upload the APK from now on

Thanks a lot – in the name of all the users obtaining it via my repo!

@MartinX3 Thanks for offering your help! I think the problems @yakov116 is mentioning should be solvable by someone familiar with Travis. And I guess it could even be configured to not place every build into "public space" – but just the ones defined such, and even just on a release if so wished. Looks like the team currently lacks time to concentrate on that task – so maybe they can take you up on your offer at a later time.

@ALL: Let's return to "good mood mode". We're not fighting against each other, but against the problems, right? :innocent: