k0shk0sh / FastHub

FastHub the ultimate GitHub client for Android.
GNU General Public License v3.0
5.71k stars 931 forks source link

edit option from file viewer #1714

Open introspectionism opened 6 years ago

introspectionism commented 6 years ago

FastHub Version: 4.6.7
Android Version: 8.1.0 (SDK: 27)
Device Information:

i am using this app for viewing and editing todo lists (.md files). having to navigate back to the overview page for editing a file is annoying.

however, thanks for a great app!

cozyplanes commented 6 years ago

PR welcome

k0shk0sh commented 6 years ago

I didn't get u, clicking on the menu button on the file actually list down edit functionality, so where is the issue in here?

k0shk0sh commented 6 years ago

yakov116 commented 6 years ago

@k0shk0sh open the file. over there he would like an option

introspectionism commented 6 years ago

@k0shk0sh (@yakov116)

yes. i would like an edit button when the file is opened. here: image

k0shk0sh commented 6 years ago

in this case i'll end up making two extra APIs ;) one to see you are owner and one to check if you are collaborator. I think the owner part is not needed if i have the username of the repo which usually i do, but another API is needed. I think this is a good feature to have, so i'm gonna accept it however can't promise anytime soon.

introspectionism commented 6 years ago

@k0shk0sh i understand. well, thanks a lot for accepting this as a feature. all the best for the future development of this app.

by the way, "Status: Completed" - wrong status?

yakov116 commented 6 years ago

@klevstul maybe he did it already :)