search

k0shk0sh / FastHub

FastHub the ultimate GitHub client for Android.
GNU General Public License v3.0
5.71k stars 932 forks source link

Improper buttons on release details view. #1745

Open janisozaur opened 6 years ago

janisozaur commented 6 years ago

FastHub Version: 4.6.7
Android Version: 8.0.0 (SDK: 26)
Device Information:

Details of release page has two buttons, "Cancel" and "OK" that serve no purpose other than to confuse user, as both close the view (see https://github.com/k0shk0sh/FastHub/issues/1742#issuecomment-382195319). There should be only one with text clearly communicating the button closes the view.

This is a follow-up to https://github.com/k0shk0sh/FastHub/issues/1742, which got closed labelled as "question", I understand that you wanted a separate issue for the bug report then.

yakov116 commented 6 years ago

@janisozaur yes thanks.

Mind to send a pr?