Cannot show more than 100 comments on an issue

[ghost]

App Version: 2.1.0

OS Version: 25

Model: samsung-kminilte

That's about all I can say.

[k0shk0sh]

Link to issue/Pr? Maximum is set by default to 200

[ghost]

@k0shk0sh https://github.com/Spookcity/ROMS-G800F/issues/10

[ghost]

I really like the new update! The app feels so complete now and I think you've implemented everything the GitHub API allows you to do.

However, this issue still hasn't been solved. Now, the app crashes when I scroll too far, which also isn't ideal

[ghost]

It might be because I scroll too fast.

[ghost]

But it also doesn't work when I scroll gently

[k0shk0sh]

@StanNL that's weird, I have really test it well from the link you provided. Strange tho. I'll see what causes it and make release fixing it.

I'm able to produce the problem & I guess its due to some emoji :D . Will fix this asap and try and make new release today

Sent from my Htc m8 using FastHub

[k0shk0sh]

It's fixed, sorry about that, it will be in today's release

Sent from my Htc m8 using FastHub

[ghost]

@k0shk0sh That's awesome! This app is getting better and better every single week and I really like it! This version feels more refined than ever before. There are a few tiny things that can be improved though.

1. It would be nice to be able to change your signature.
2. I believe the "teal" accent colour isn't teal.
3. And lastly, the reply/quote text you recently added gets cut off on the top, not the bottom like you would expect (see screenshot).

Sent from my Samsung kminilte using FastHub

[ghost]

You used #00BEA5 for your "teal" color code, while it should be #009688 in my opinion, because this just looks like light blue. Not that it's a big issue, but feedback is always welcome, right?

[k0shk0sh]

for the teal, it should be #00796B according to material design colors.

[ghost]

Well I meant # 00 96 88, but GitHub (the desktop version) somehow removed the leading zeros because it thought I was referring to an issue. # 00796B looks good as well, but like I said, you chose # 00BEA5, which is more like a light blue color.

[k0shk0sh]

I didn't do that part to be host, but I changed that now. i'm going to make a release in awhile. after the issue you opened.

[ghost]

Great! Thanks

Sent from my Samsung kminilte using FastHub

[ghost]

I think I'm going to use this as a 'question' topic if you don't mind.

Firstly, I was wondering if your notifications shouldn't appear in the feed tab.

Also, some of the bold 'action indicators' in the feed tab, aren't in correct English. I'm talking about things like Person X created comment on issue Y, when I talk about those action indicators. So here's a list of the indicators that need to be changed.

• Person X created comment on issue Y should be: Person X commented on issue Y
• Person X comment on commit Y should be: Person X commented on commit Y (mind the ed behind comment that indicates a past tense)
• Person X published released Y should be: Person X released Y.

That's all of the "indicators" (I still don't know what to call them) that I could see. If you could link me to the file where these strings come from, I might be able to update them all. English isn't my native language either, but these just sound much better in my opinion.

Sent from my Samsung kminilte using FastHub

[ghost]

Another one: Person X created comment on pull request Y should be Person X commented on pull request Y

Sent from my Samsung kminilte using FastHub

[yakov116]

@StanNL Thanks for reporting. @k0shk0sh and I will one day (ahem) and go through all of them and correct them all. It is my understanding the we are taking the way github reports it in the api.

[ghost]

@yakov116 I might be able to help you with that if necessary

Sent from my Samsung kminilte using FastHub

[k0shk0sh]

@StanNL you are welcome to join our slack group

Sent from my Htc m8 using FastHub