k0shk0sh / FastHub

FastHub the ultimate GitHub client for Android.
GNU General Public License v3.0
5.71k stars 931 forks source link

HTML Rendering issues inside code box #799

Closed ghost closed 7 years ago

ghost commented 7 years ago

FastHub Version: 4.0.3
Android Version: 5.1 (SDK: 22)

Was reading the ch1 of YDKJS came across this badly or hardly rendered < span > element. I assumed there must be something I'm missing checked the same stuff in save page offline it rendered the code box correctly (this works correctly on the browser). screenshot_2017-07-27-22-50-33 screenshot_2017-07-27-22-52-43

original repo i came from

https://github.com/P1xt/p1xt-guides/blob/master/wd-cs.md

Link to ch1 of issue page

https://github.com/getify/You-Dont-Know-JS/blob/master/up%20%26%20going/ch1.md

yakov116 commented 7 years ago

@LordKrishna91 please include a link to the repo

Ok I see it. Thanks for reporting

ghost commented 7 years ago

@yakov116 check below the screenshots for links to original refered repo and the ch1 rendering issue repo

yakov116 commented 7 years ago

@LordKrishna91 Thanks I see it.

@k0shk0sh Github allows HTML formatting inside the .md. This is the issue

k0shk0sh commented 7 years ago

the reason for that it was that the html entities are escaped & I don't know why :D a simple replace was enough tho.

.replaceAll("&lt;", "<")
.replaceAll("&gt;", ">")