search

k0sproject / k0s

k0s - The Zero Friction Kubernetes
https://docs.k0sproject.io
Other
3.75k stars 365 forks source link

Sanitize component model #4357

Open jnummelin opened 6 months ago

jnummelin commented 6 months ago

From @twz123 in https://github.com/k0sproject/k0s/pull/4213#discussion_r1584391276

I still think we should eventually sanitize our component model. Either use the context from Start and don't have a Stop method, or only use the Stop method to stop the component, disregarding the context from Start. There's just no sense in having a Stop method if it's a no-op even for components that are actually running and need to be stopped.

We would need to break up the component interface a bit and go through all the components to use the root context properly.

twz123 commented 6 months ago

/xref #1844

github-actions[bot] commented 5 months ago

The issue is marked as stale since no activity has been recorded in 30 days

github-actions[bot] commented 4 months ago

The issue is marked as stale since no activity has been recorded in 30 days

github-actions[bot] commented 3 months ago

The issue is marked as stale since no activity has been recorded in 30 days

github-actions[bot] commented 2 months ago

The issue is marked as stale since no activity has been recorded in 30 days

github-actions[bot] commented 1 month ago

The issue is marked as stale since no activity has been recorded in 30 days

github-actions[bot] commented 3 days ago

The issue is marked as stale since no activity has been recorded in 30 days