k0sproject / k0s

k0s - The Zero Friction Kubernetes
https://docs.k0sproject.io
Other
3.13k stars 353 forks source link

Cleanup unknown Helm chart manifest files #4705

Closed twz123 closed 2 days ago

twz123 commented 3 days ago

Description

Keep track of the generated filenames when reconciling Helm Chart extensions. After all files have been synchronized, remove any remaining unknown Helm chart manifest files. This way the synchronization will work correctly even if the Helm chart extension names and orders are changed. Collect errors during reconciliation in extension controller. This way, the reconciliation gets as close as possible to the desired state, even if some things in between are failing.

Fixes:

Type of change

How Has This Been Tested?

Checklist:

k0s-bot commented 2 days ago

Backport failed for release-1.30, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.30
git worktree add -d .worktree/backport-4705-to-release-1.30 origin/release-1.30
cd .worktree/backport-4705-to-release-1.30
git switch --create backport-4705-to-release-1.30
git cherry-pick -x e0aa6a4977041b18f303d60c3dac7b330122fe22 394418d848de24ddfdd03f7f574d4e15f6ff1791 c1f8c7533a3bbaaa934620b14ff7da56fbed3f8f