bug: make sure we close opened containerd connections - Githubissues

k0sproject / k0s

k0s - The Zero Friction Kubernetes

https://docs.k0sproject.io

Other

3.13k stars 353 forks source link

bug: make sure we close opened containerd connections #4707

Closed ricardomaraschini closed 2 days ago

ricardomaraschini commented 3 days ago

Description

if we fail to list images using the containerd client we better close the connection before creating a new one.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

[x] Manual test
[ ] Auto test added

Checklist:

[x] My code follows the style guidelines of this project
[x] My commit messages are signed-off
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

twz123 commented 2 days ago

Thanks :+1:

k0s-bot commented 2 days ago

Successfully created backport PR for release-1.30:

4713